Skip to content

♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format #6797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 28, 2024
Merged

♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format #6797

merged 10 commits into from
Nov 28, 2024

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 21, 2024 •
edited
Loading

What do these changes do?

Adapt the PROJECTS_INACTIVITY_INTERVAL env var to be used with an interval in ISO 8601 format.

In Pydantic v1 numbers were considered seconds by default, but in Pydantic v2 they generate a WARNING.

Related issue/s

How to test

Dev-ops checklist

⚠️ See: MR 1113

@giancarloromeo giancarloromeo mentioned this pull request Nov 21, 2024
Closed
@giancarloromeo giancarloromeo changed the title ♻️ Fix PROJECTS_INACTIVITY_INTERVAL env var ♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format Nov 21, 2024
@giancarloromeo giancarloromeo self-assigned this Nov 21, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 21, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (c85f825) to head (c89d68c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6797      +/-   ##
==========================================
+ Coverage   88.35%   88.61%   +0.26%     
==========================================
  Files        1538      619     -919     
  Lines       61475    30920   -30555     
  Branches     2166      318    -1848     
==========================================
- Hits        54315    27400   -26915     
+ Misses       6829     3460    -3369     
+ Partials      331       60     -271
Flag Coverage Δ
integrationtests 64.77% <100.00%> (+<0.01%) ⬆️
unittests 87.16% <100.00%> (+0.89%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.13% <ø> (+0.09%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.62% <ø> (-0.13%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.68% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85f825...c89d68c. Read the comment docs.

@giancarloromeo giancarloromeo changed the title ♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format ♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format Nov 22, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 26, 2024 08:20
pcrespov
pcrespov approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Careful with the osparc-config MR!!! This is a breaking change so you need to create different branches for those deploys where these variables cannot be applied right away until this code is released there

@giancarloromeo
Copy link
Contributor Author

giancarloromeo commented Nov 26, 2024

Thx. Careful with the osparc-config MR!!! This is a breaking change so you need to create different branches for those deploys where these variables cannot be applied right away until this code is released there

Please, read the MR's description.

The variable type is already dt.timedelta in all deployments, so it's safe to make the change in 1-shot.

GitHK
GitHK approved these changes Nov 26, 2024
View reviewed changes
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 26, 2024 11:28
mrnicegyu11
mrnicegyu11 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo merged commit da8adc3 into ITISFoundation:master Nov 28, 2024
85 of 90 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
@giancarloromeo giancarloromeo deleted the is6791/fix-projects-inactivity-interval-env-var branch December 17, 2024 12:07
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@giancarloromeo giancarloromeo

Labels

None yet

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

Uniform the timedelta format in ENV vars

7 participants

@giancarloromeo @GitHK @mrnicegyu11 @pcrespov @sanderegg @YuryHrytsuk @matusdrobuliak66